Rename periodic_niggli_reduce to niggli_reduce_periodic#223
Merged
atztogo merged 1 commit intospglib:developfrom Jan 25, 2023
atztogo:niggli
Merged
Rename periodic_niggli_reduce to niggli_reduce_periodic#223atztogo merged 1 commit intospglib:developfrom atztogo:niggli
atztogo merged 1 commit intospglib:developfrom
atztogo:niggli
Conversation
In addition, test_niggli_delaunay.py was migrated to pytest.
Codecov ReportBase: 93.61% // Head: 93.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
- Coverage 93.61% 93.34% -0.27%
===========================================
Files 15 15
Lines 908 902 -6
===========================================
- Hits 850 842 -8
- Misses 58 60 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
This is only internal right? No need to label this change? |
Collaborator
Author
|
Thanks for watching it.
Correct!
I think No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a naming convention of non static function, the function name
periodic_niggli_reducewas changed toperiodic_niggli_reduce.In addition,
test_niggli_delaunay.pywas migrated to pytest from python unittest.Ping @site-g just for your information.