Temporary fix for scikit-build on macs#214
Conversation
|
@atztogo Can you confirm this works? I will upstream this fix to scikit-build later if it does |
|
@LecrisUT, thanks for your quick work. Almost. The following change at least made it work. % git diff setup.py
diff --git a/python/setup.py b/python/setup.py
index f5d40e1..42a79eb 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -5,9 +5,9 @@ from skbuild import setup
# TODO: Temporary fix for #212
# Remove and update dependency when scikit-build/scikit-build#717 is resolved
import platform
-if platform.version() == 'Darwin':
+if platform.system() == 'Darwin':
mac_version, _, mac_arch = platform.mac_ver()
- mac_version = f"{mac_version}-{mac_arch}"
+ mac_version = f"{mac_version}"
else:
mac_version = None
@@ -75,7 +75,7 @@ setup(
tests_require=[
"pyyaml",
],
- cmake_args=['-DWITH_Python=ON', '-DWITH_TESTS=OFF', '-DUSE_OMP=OFF', '-DBUNDLE_Python_SharedLib=ON'],
+ cmake_args=cmake_args,
cmake_source_dir="..",
extras_require=extras_require,
) |
Signed-off-by: Cristian Le <[email protected]>
|
Oh god. I've derped that commit bad. Sorry about that. I am surprised why we don't need to set up |
Codecov ReportBase: 64.34% // Head: 64.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #214 +/- ##
===========================================
- Coverage 64.34% 64.00% -0.34%
===========================================
Files 18 18
Lines 1321 1328 +7
===========================================
Hits 850 850
- Misses 471 478 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Merged. Thanks @LecrisUT. Your PR worked on my macOS. |
3 participants
Fixes #212