Add benchmark for get_symmetry_dataset#207
Merged
lan496 merged 3 commits intospglib:developfrom Nov 26, 2022
Merged
Conversation
Codecov ReportBase: 85.57% // Head: 85.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #207 +/- ##
===========================================
- Coverage 85.57% 85.34% -0.24%
===========================================
Files 17 18 +1
Lines 1352 1358 +6
===========================================
+ Hits 1157 1159 +2
- Misses 195 199 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
@lan496, thanks for your these works. I confirmed the benchmark works. I read through the files changed. Thanks for improvements for non-benchmark stuff, too. pytest-benchmark was new to me. I have nothing to say than LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmark script
python/test/test_benchmark.py, which callsget_symmetry_datasetfor all cells inpython/test/data. This benchmark is not performed as default (--benchmark-skip).Here is an example of the benchmarking:
The following changes are also added though they do not relate to the issue directly:
pip install -e .[testing]doc/development/performance.md