Add layer group python interface#201
Merged
atztogo merged 4 commits intospglib:developfrom Nov 22, 2022
Merged
Conversation
added 4 commits
November 6, 2022 15:17
LecrisUT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a perliminary python interface, which is naively based to very large extent based on reusing the previous code. What remains open is modifications of the interface for special needs of layer group (naming, method help etc.).
In addition, more exhaustive testing is needed. A single test is added for now.
I would be happy to polish this further and add tests.