Implement spg_get_spacegroup_type_from_symmetry#176
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
+ Coverage 84.63% 85.19% +0.55%
===========================================
Files 14 16 +2
Lines 1204 1317 +113
===========================================
+ Hits 1019 1122 +103
- Misses 185 195 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
atztogo
commented
Aug 6, 2022
Collaborator
Author
|
lan496
reviewed
Aug 7, 2022
lan496
reviewed
Aug 7, 2022
Member
lan496
left a comment
There was a problem hiding this comment.
LGTM! I left a tiny comment.
Yesterday, I learned unittest2pytest, which seems to help migrate bulit-in unittest to pytest.
Collaborator
Author
For me, manual migration is easy because I wrote the current tests. But I agree, in general, it is a good idea to use those convenient tools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spg_get_spacegroup_type_from_symmetryis implemented to replacespg_get_hall_number_from_symmetrythat is deprecated at v2.0.