plugins: keepkey: vendor our fork of keepkeylib (as git submodule)#9650
Merged
SomberNight merged 2 commits intospesmilo:masterfrom Mar 17, 2025
Merged
plugins: keepkey: vendor our fork of keepkeylib (as git submodule)#9650SomberNight merged 2 commits intospesmilo:masterfrom
SomberNight merged 2 commits intospesmilo:masterfrom
Conversation
we will instead bundle our own fork, as a git submodule, https://github.com/spesmilo/electrum-keepkeylib related spesmilo#7922 and keepkey/python-keepkey#146 (i.e. upstream keepkeylib is unmaintained)
now that the keepkey pb2's are regenerated using the "new" format, we don't need an old python3-protobuf to parse them ref spesmilo#7922
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #9581
The difference is that this PR adds our fork of keepkeylib as a git submodule, instead of including it directly into the git tree. This avoids polluting the tree.
Our fork of keepkeylib has the protobuf-generated code regenerated with more modern protoc, and a lot of altcoin stuff is removed.
Also see description of prev PR: