Skip to content

plugins: keepkey: vendor our fork of keepkeylib (as git submodule)#9650

Merged
SomberNight merged 2 commits intospesmilo:masterfrom
SomberNight:202503_keepkey
Mar 17, 2025
Merged

plugins: keepkey: vendor our fork of keepkeylib (as git submodule)#9650
SomberNight merged 2 commits intospesmilo:masterfrom
SomberNight:202503_keepkey

Conversation

@SomberNight
Copy link
Member

replaces #9581

The difference is that this PR adds our fork of keepkeylib as a git submodule, instead of including it directly into the git tree. This avoids polluting the tree.

Our fork of keepkeylib has the protobuf-generated code regenerated with more modern protoc, and a lot of altcoin stuff is removed.

Also see description of prev PR:

This adds keepkeylib into our git tree. We will vendor it that way from now, instead of declaring it as an external dependency.

Upstream keepkeylib is effectively unmaintained -- but the only problem with it is that it requires an old version of protobuf. (see keepkey/python-keepkey#146)
By vendoring it, we can fix that ourselves.

keepkeylib is taken from PyPI, at keepkey==6.3.1, which is the version we have sha256 pinned for 5 years.

This also vendors the corresponding source protobuf files, which were not part of the keepkeylib sdist. Those are taken from the git repo, at the corresponding commit (for v6.3.1).

Subsequent commits

  • strip out some of the shitcoin crap from keepkeylib, though only the parts that were easy to remove
  • regenerate the pb2 files using protoc-21.12 (which is the version currently in debian stable, already much newer than what was previously used)

closes #7922

now that the keepkey pb2's are regenerated using the "new" format,
we don't need an old python3-protobuf to parse them

ref spesmilo#7922
@SomberNight SomberNight merged commit 75cef43 into spesmilo:master Mar 17, 2025
2 of 13 checks passed
@SomberNight SomberNight added this to the 4.6.0 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protobuf breaking changes between 3.20.x and 4.21 (4.x)

1 participant