Skip to content

wizard: extend derivation dialog to also let user select script type #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ecdsa merged 1 commit into from
Jun 26, 2018
Merged

wizard: extend derivation dialog to also let user select script type #4465

ecdsa merged 1 commit into from
Jun 26, 2018

Conversation

@SomberNight
Copy link
Member

@SomberNight SomberNight commented Jun 26, 2018

  • extend derivation dialog to also let user select script type
  • enable segwit multisig for bip39/hw wallets

The default paths for segwit multisig are as described in #4352 (comment) , i.e.

m / purpose' / coin_type' / account' / script_type' / change / address_index

where purpose = 48, account = 0, and
script_type = 1 for p2wsh-p2sh multisig, and
script_type = 2 for p2wsh multisig

This supersedes #4464 and #4443

wizard_script_and_der1
wizard_script_and_der2

@ecdsa ecdsa merged commit 357ff8e into spesmilo:master Jun 26, 2018
This was referenced Jun 26, 2018
Closed
Closed
@SomberNight SomberNight mentioned this pull request Apr 19, 2019
Closed
@maxtannahill maxtannahill mentioned this pull request Aug 27, 2019
Merged
@SomberNight SomberNight added topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py topic-wizard 🧙‍♂️ related to wallet creation/restore wizard labels Oct 2, 2019
@Sjors Sjors mentioned this pull request Oct 29, 2019
Closed
2 tasks
@SomberNight SomberNight mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py topic-wizard 🧙‍♂️ related to wallet creation/restore wizard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SomberNight @ecdsa