Repository navigation
don't read 'the twenty fifth of december' as a fraction - #1257
Merged
spencermountain merged 1 commit intoNov 2, 2026
Merged
Conversation
The '[#Card+ #Ord] of .' fraction rule also caught spelled-out compound
ordinals, so 'twenty fifth of' became 20/5 and the dates plugin read
'the twenty fifth of december' as december 4th. A fraction with more
than one part has a plural ordinal ('two thirds of'), and 'one third of'
is already covered by the (a|one) rule, so only match a plural ordinal
here.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
|
hahahaha |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[#Card+ #Ord] of .fraction rule also caught spelled-out compound ordinals:A fraction with a numerator above one has a plural ordinal ('two thirds of'), and 'one third of' / 'a twenty fifth of' are already covered by the (a|one) rule, so this rule now only takes a plural ordinal. 'two thirds of', 'three fifths of' and 'nine tenths of' are unchanged. Tests added to fractions.test.js and to the dates plugin's explicit-dates test; they fail on dev and pass with the change. The full suite and the plugin suites pass.
I used Claude Code to write this change.