Fix crash in SegmentShape.Calculate when lines list is empty#2036
Merged
patriksvensson merged 2 commits intospectreconsole:mainfrom Mar 3, 2026
Merged
Conversation
Adds a unit test to verify that SegmentShape.Calculate returns a zero size when called with an empty lines collection. This test reproduces a bug where an InvalidOperationException was thrown due to calling Enumerable.Max on an empty collection.
Prevents InvalidOperationException when SegmentShape.Calculate is called with an empty lines list. Checks if lines.Count are greater than 0 before calling Enumerable.Max, returning width 0 if the list is empty. Fixes #2015
Contributor
Author
|
@microsoft-github-policy-service agree |
patriksvensson
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Changes
SegmentShape.Calculatereturns a zero size when called with an emptylinescollection.InvalidOperationExceptioncaused by callingEnumerable.Maxon an empty list.0whenlinesis empty instead of throwing.This ensures that rendering an empty
Tablewith hidden headers does not crash during Live rendering.Please upvote 👍 this pull request if you are interested in it.