Revert commits related to modernization of code#1999
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Jan 8, 2026
Merged
Revert commits related to modernization of code#1999patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
Contributor
patriksvensson
commented
Jan 8, 2026
patriksvensson
commented
- Revert f6e1368: "Fixes problems with extension blocks and params keyword"
- Revert 7965168: "Add modernization commit to .git-blame-ignore-revs"
- Revert 3f57df5: "Modernization of the code base"
patriksvensson
force-pushed
the
feature/revert
branch
from
6f5a3c6 to
3001c51
Compare
patriksvensson
requested review from
Copilot
and removed request for
0xced,
nils-a and
phil-scott-78
There was a problem hiding this comment.
Pull request overview
This pull request reverts three commits that attempted to modernize the codebase. The changes primarily involve:
- Reverting the use of C# "extension blocks" (an experimental/proposed feature using
extension()syntax) back to traditional static extension methods - Moving extension methods from inline definitions within class files to separate dedicated extension files
- Replacing
ArgumentNullException.ThrowIfNull()calls with traditionalif (x is null) { throw new ArgumentNullException(nameof(x)); }patterns - Removing a polyfill reference from the project file
Reviewed changes
Copilot reviewed 201 out of 201 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| TreeNode.cs, Tree.cs, TextPath.cs, etc. | Removed extension blocks that were embedded within class files |
| TreeNodeExtensions.cs, TreeExtensions.cs, TextPathExtensions.cs, etc. | Added separate extension method files with traditional static extension method syntax |
| Table.cs, Paragraph.cs, Grid.cs, etc. | Reverted ArgumentNullException.ThrowIfNull() to traditional null checks |
| Spectre.Console.csproj | Removed polyfill reference |
| StringUriExtensions.cs, CharExtensions.cs, TextWriterExtensions.cs | New utility extension files added |
| ExceptionFormatter.cs | Reverted extension block to traditional static method |
| MultiSelectionPrompt.cs | Minor formatting changes (line breaks) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.