Add source generation for colors, emojis and spinners#1995
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Jan 6, 2026
Merged
Add source generation for colors, emojis and spinners#1995patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
patriksvensson
approved these changes
Jan 6, 2026
Contributor
patriksvensson
left a comment
patriksvensson
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suspiciously easy. Included in the project are the old generated emojis/colors/spinners and a unit test verifying anything the original is in the source generated. This should be dropped eventually, but figured nice to have while reviewing the code.
Beyond ensuring all the values are the same, I did try my best to make this as performant as I know how. Reading a mb of emojis in json is obviously something we don't want to be doing all the time, but I have it flowing through pipelines that are performant so it should hopefully avoid that. On my machine, with Rider and VS Code I saw it generate the code about 20 times over about 5 minutes as I was editing and even when it ran it was only a 50ms hit.
This also drops the Generator projects, the Asciicast stuff is no longer needed either with the new docs.