Skip to content

Fixed link not dispalyed in markup in Style.cs and added unit test cases#1750

Merged
patriksvensson merged 3 commits intospectreconsole:mainfrom
Elementttto:Bug-Fix-#1642
Jun 2, 2025
Merged

Fixed link not dispalyed in markup in Style.cs and added unit test cases#1750
patriksvensson merged 3 commits intospectreconsole:mainfrom
Elementttto:Bug-Fix-#1642

Conversation

@Elementttto
Copy link
Copy Markdown
Contributor

@Elementttto Elementttto commented Feb 1, 2025

fixes #1642

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Modified method ToMarkup() in Style.cs to fill in the link as required and added two unit test cases to cover the changes.


Please upvote 👍 this pull request if you are interested in it.

@Elementttto
Copy link
Copy Markdown
Contributor Author

Hi @patriksvensson
Would you mind reviewing this PR?

@Elementttto
Copy link
Copy Markdown
Contributor Author

Hi @patriksvensson
Thanks for pointing it out. I have addressed the comment.

@patriksvensson patriksvensson merged commit bd0e2d3 into spectreconsole:main Jun 2, 2025
3 checks passed
@patriksvensson
Copy link
Copy Markdown
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

This was referenced Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style.ToMarkup() does not include the link

2 participants