Changes Emoji dictionary to OrdinalIgnoreCase for performance#1691
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Nov 20, 2024
Merged
Changes Emoji dictionary to OrdinalIgnoreCase for performance#1691patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
This code is ran on startup, and instantiating a new InvariantCultureIgnoreCase was taking up 11ms, which was half the time in AOT.
patriksvensson
approved these changes
Nov 20, 2024
This was referenced Jul 22, 2025
This was referenced Jul 30, 2025
This was referenced Aug 11, 2025
This was referenced Aug 19, 2025
This was referenced Feb 16, 2026
This was referenced Feb 24, 2026
Closed
Open
This was referenced Mar 4, 2026
This was referenced Mar 12, 2026
This was referenced Mar 20, 2026
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the AOT stuff I was also profiling some code and ran across this taking up a huge chunk of the time spent initializing the app. Switching to OrdinalIgnoreCase actually gave a 100% boost in my TTFRE (time to first rocketship emoji) benchmark.
And fwiw, this puts Spectre.Console a few MS off of regular Console.WriteLine...
