Improve exception if a (multi)selection prompt is used incorrectly#1637
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Sep 11, 2024
Merged
Improve exception if a (multi)selection prompt is used incorrectly#1637patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
Before this commit, the selection prompt would throw an `InvalidOperationException` (Sequence contains no elements) and the multi selection prompt would throw an `ArgumentOutOfRangeException` (Index was out of range. Must be non-negative and less than the size of the collection.) Both would occur because the prompts were never meant to be empty.
patriksvensson
approved these changes
Sep 11, 2024
Contributor
patriksvensson
left a comment
patriksvensson
left a comment
There was a problem hiding this comment.
This makes perfect sense. LGTM 👍
This was referenced Jul 22, 2025
This was referenced Jul 30, 2025
This was referenced Aug 11, 2025
This was referenced Feb 16, 2026
This was referenced Feb 24, 2026
Closed
Open
This was referenced Mar 4, 2026
This was referenced Mar 12, 2026
This was referenced Mar 20, 2026
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the selection prompt would throw an
InvalidOperationException(Sequence contains no elements) and the multi selection prompt would throw anArgumentOutOfRangeException(Index was out of range. Must be non-negative and less than the size of the collection.)Both would occur because the prompts were never meant to be empty.
Maybe we should change the
SelectionPromptandMultiSelectionPromptconstructors to always require at least one item so that this situation could never occur? But that would be a breaking change and should be discussed in a separate issue. This one is not breaking and just provides a more understandable error message.Please upvote 👍 this pull request if you are interested in it.