Skip to content

Add explicit werkzeug dependency#1302

Merged
hjacobs merged 1 commit intospec-first:masterfrom
patrickkwang:patch-1
Jun 24, 2021
Merged

Add explicit werkzeug dependency#1302
hjacobs merged 1 commit intospec-first:masterfrom
patrickkwang:patch-1

Conversation

@patrickkwang
Copy link
Copy Markdown
Contributor

Fixes #1149.

Changes proposed in this pull request:

  • add explicit werkzeug dependency
  • set lower version bound to 1.0 - I'm not sure if there are earlier versions that would break things.
  • set upper version bound to 2.0 - Any breaking changes could be bad.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 11, 2020

Coverage Status

Coverage remained the same at 96.878% when pulling ba9a91b on patrickkwang:patch-1 into 1ed14fb on zalando:master.

Copy link
Copy Markdown

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This should've been here from the moment someone wrote that from werkzeug import FileStorage line.

@hjacobs
Copy link
Copy Markdown
Contributor

hjacobs commented Jun 24, 2021

👍

@hjacobs hjacobs merged commit 2d03c3c into spec-first:master Jun 24, 2021
@hjacobs hjacobs added this to the 2.8 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'FileStorage' from 'werkzeug'

5 participants