Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
The tag is not recognisable by Javadoc, has to escaped it. Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
left a comment
There was a problem hiding this comment.
Let's leave the original notice texts in the source file since it is recommended by the Apache software foundation: https://www.apache.org/legal/apply-license.html
The other changes is to keep Java 8 compliance - last time I tried to change that, I got complaints from the user community that their company is still using Java 8.
|
@bact - If you could rebase to the latest, it should fix the CI failure |
|
Since I would like to get a release out today and this change is mostly documentation, I'll include it in the the next release after 2.0.0-RC2 |
Signed-off-by: Arthit Suriyawongkul <[email protected]> Co-authored-by: Gary O'Neall <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]> Co-authored-by: Gary O'Neall <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]> Co-authored-by: Gary O'Neall <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall I have add back the short license header as suggested. Note that the guideline you have mentioned is for the code that is developed at the Apache Software Foundation.
So it is a guideline for Apache products, not a guideline for Apache license. -- Btw, for the URL changes, the guideline also said: "https is acceptable in place of http for the URL" |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
Note: a Pages settings to point to gh-pages branch is needed after merge. Update: Done. API doc avail at https://spdx.github.io/spdx-java-tagvalue-store/ |
<text> </text>in Javadoc, it has to be escaped@authortoSPDX-FileContributorDemo: https://bact.github.io/spdx-java-tagvalue-store/
(Note: a Pages settings to point to gh-pages branch is needed after merge + CI run)