Skip to content

Comments

Check for proper extracted license info ID's#39

Merged
goneall merged 2 commits intomasterfrom
issue31
Feb 7, 2023
Merged

Check for proper extracted license info ID's#39
goneall merged 2 commits intomasterfrom
issue31

Conversation

@goneall
Copy link
Member

@goneall goneall commented Feb 7, 2023

Fixes #31

Signed-off-by: Gary O'Neall [email protected]

} else if (tag.equals(constants.getProperty("PROP_LICENSE_ID"))) {
checkAnalysisNull();
if (value == null || !value.startsWith(SpdxConstants.NON_STD_LICENSE_ID_PRENUM)) {
if (LicenseInfoFactory.isSpdxListedLicenseId(value) || LicenseInfoFactory.isSpdxListedLicenseId(value)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdentityBinaryExpression: A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to LicenseInfoFactory.isSpdxListedLicenseId(value).


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@goneall goneall merged commit 0f7157f into master Feb 7, 2023
@goneall goneall deleted the issue31 branch February 7, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant