Conversation
Fixes #31 Signed-off-by: Gary O'Neall <[email protected]>
| } else if (tag.equals(constants.getProperty("PROP_LICENSE_ID"))) { | ||
| checkAnalysisNull(); | ||
| if (value == null || !value.startsWith(SpdxConstants.NON_STD_LICENSE_ID_PRENUM)) { | ||
| if (LicenseInfoFactory.isSpdxListedLicenseId(value) || LicenseInfoFactory.isSpdxListedLicenseId(value)) { |
There was a problem hiding this comment.
IdentityBinaryExpression: A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to LicenseInfoFactory.isSpdxListedLicenseId(value).
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Gary O'Neall <[email protected]>
Fixes #31
Signed-off-by: Gary O'Neall [email protected]