GitHttpServer broken by git/git-daemon Alpine update - #106
Merged
sparsick merged 4 commits intoMay 19, 2024
Conversation
…we're getting the exception we expect
harmonic-jamie
changed the title
harmonic-jamie
changed the title
Contributor
Author
|
@sparsick - this builds and tests pass for me now. Happy to get your feedback. |
Contributor
Author
|
Fixes #105 |
harmonic-jamie
changed the title
harmonic-jamie
changed the title
sparsick
requested changes
May 18, 2024
sparsick
left a comment
sparsick
left a comment
Owner
There was a problem hiding this comment.
Thanks for your Pr. I have only one little thing to change. I commented it in the code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
============================================
+ Coverage 88.81% 88.88% +0.06%
Complexity 49 49
============================================
Files 7 7
Lines 161 162 +1
Branches 7 7
============================================
+ Hits 143 144 +1
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
sparsick
changed the title
Owner
|
Thanks @harmonic-jamie for your fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
gitto theapk addstatement appears to let the container build, however the tests still fail with an500: Internal Server errorat a later stage.Will update the associated issue.