busy_handler_timeout pt2#456
Conversation
|
Debugging now. |
|
@flavorjones: It seems that Do you see something wrong in the tests, or is Windows just behaving differently with threads? |
|
maybe @tenderlove has time to take a look? |
|
You know what, why do we need a test that the |
|
@flavorjones: Removing that test, as fully expected, brings us to green. I see you just reverted, so I will need to add back the actual method, but that is easy enough. If you agree that the one test about |
|
@flavorjones @tenderlove This adds the code back with a single robust test that asserts the new code behaves how we want. Should be good to go |
|
@flavorjones @tenderlove: Is there anything I need to do to get this reviewed? Not trying to be pushy, only proactive. If you simply are busy in the short-term and can't review PRs in this repo, I understand. I'm only pinging because I know as a maintainer on a level probably with 10x or 100x fewer notifications, it is easy to "mark something as read" and then it slips into the ever-flowing stream of notifications and things to consider. |
|
@fractaledmind no worries, thanks for pinging. CI is green and the patch seems good, so I'll merge! |
Since #443 required a revert (#457) because the test for
busy_timeoutholding the GVL such that other working threads could not progress was flaky (particularly onwindows-latest, packagedCI builds), this PR re-introduces thebusy_handler_timeoutbut with only one resilient test that thebusy_handler_timeoutdefinitely does allow other working threads to progress. The negative test ofbusy_timeoutis unnecessary in addition to being flaky.