Skip to content

Set STRINGS_FILE_OUTPUT_ENCODING build setting to "binary"#2712

Merged
zorgiepoo merged 2 commits into
sparkle-project:2.xfrom
nickasd:2.x
Apr 2, 2025
Merged

Set STRINGS_FILE_OUTPUT_ENCODING build setting to "binary"#2712
zorgiepoo merged 2 commits into
sparkle-project:2.xfrom
nickasd:2.x

Conversation

@nickasd

@nickasd nickasd commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

This reduces the final framework bundle size by 193 KB.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

macOS version tested: macOS 15.3.2

@zorgiepoo

Copy link
Copy Markdown
Member

Thanks. Tested this works when changing language on 15.4 (24E248), 10.14.6 VM.

@zorgiepoo zorgiepoo added this to the 2.8 milestone Apr 2, 2025
@zorgiepoo zorgiepoo merged commit 1dec7dd into sparkle-project:2.x Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants