Skip to content

Guard update timer update check against sessionInProgress#2561

Merged
zorgiepoo merged 1 commit into
2.xfrom
guard-update-timer
May 12, 2024
Merged

Guard update timer update check against sessionInProgress#2561
zorgiepoo merged 1 commit into
2.xfrom
guard-update-timer

Conversation

@zorgiepoo

Copy link
Copy Markdown
Member

Make sure we don't perform a background update check when a user update check was initiated. This may have regressed from #2295.

Also replaces an assert with an error log if the _driver already exists.

Fixes #2560

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested scheduled update checks still works with test app and user can still check for updates.

macOS version tested: 14.4.1 (23E224)

Make sure we don't perform a background update check when a user update check was initiated. This may have regressed from #2295.

Also replaces an assert with an error log if the _driver already exists.

Fixes #2560
@zorgiepoo zorgiepoo added this to the 2.6.3 milestone May 12, 2024
@zorgiepoo zorgiepoo merged commit be8247e into 2.x May 12, 2024
@zorgiepoo zorgiepoo deleted the guard-update-timer branch May 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when running checkForUpdates()

1 participant