Merged
Conversation
There are three issues with the pipeline: * `x` and `x cflags=-O3` are unified, but the tutorial expects these to be concretized separately * The concretization time is very long, and sometimes times out after 1h * It no longer works with `spack@develop` due to changes related to preventing compiler mixing. All these issues are caused by `unify: when_possible` in an attempt to bootstrap GCC 12. Soon enough there'll be a proper, faster way to do this in Spack. For now, disable this stack so we can bump Spack. Signed-off-by: Harmen Stoppels <[email protected]>
haampie
requested review from
kwryankrattiger and
zackgalbreath
as code owners
haampie
added
the
pipelines:urgent
alalazo
approved these changes
Feb 4, 2026
Member
|
I think we need to revert this -- this is going to lead to a very broken tutorial in the long run, instead of a tutorial that has a single spec we're not happy with. |
becker33
added a commit
that referenced
this pull request
Feb 5, 2026
This reverts commit c3ce4ac. Signed-off-by: Gregory Becker <[email protected]>
alalazo
added a commit
to alalazo/spack-packages
that referenced
this pull request
Feb 5, 2026
This reverts commit c3ce4ac.
alecbcs
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Revert "ci: disable tutorial pipeline (#3249)" * Revert "tutorial stack: use when_possible and bootstrap gcc12 (new container) (#2277)" This commit re-enables the tutorial stack without using `when_possible` which was leading to extremely long multi round concretization times post spack/spack#51796. Although this implementation of the tutorial stack is not technically correct when using compilers as nodes, it'll allow us to continue to ensure that all of the components of the stack build and are not accidentally broken due to a package PR. The long term solution here is to merge spack/spack#51891 which allows for multiple concretization groups in an environment and thus allows us to bootstrap a gcc compiler and then use it to build additional specs in the tutorial. --------- Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three issues with the pipeline:
xandx cflags=-O3are unified, but the tutorial expects these tobe concretized separately
spack@developdue to changes to compilermixing.
All these issues are caused by
unify: when_possiblein an attempt tobootstrap GCC 12.
Soon enough there'll be a proper, faster way to do this in Spack. For
now, disable this stack so we can bump Spack.