py-scipy: add lowerbound for meson version#3234
Conversation
Signed-off-by: Harmen Stoppels <[email protected]>
|
Seems fine with me. Can you add a |
Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Harmen Stoppels <[email protected]>
|
@eli-schwartz do you want to give this a quick review before I merge? |
f5fbbc6 to
0f9e321
Compare
|
This seems reasonable to me. Although meson is depended on indirectly via py-meson-python, the version constraint is only a minimum "to ensure the build backend wiring is compatible". It is entirely normal for projects to depend on a newer version in meson.build. Although pip install in an isolated build venv generally installs the latest version, and you can "get away with" not requiring a suitable version (probably), this is not reliable or robust when the version from an existing environment may be used, and users for example decide that they wish to upgrade scipy, and only scipy. Specifying the direct build constraints is therefore necessary in order to prevent build failures; this PR prevents build failures, so 👍 |
Yup, this is what you get when you haven't bumped |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
Apparently this change causes the tutorial pipeline to get stuck concretizing for 1h+, six times in a row :) That should not be a blocker, it's just that that stack is configured incorrectly. So would suggest to force merge this after #3255 is closed. |
Meson is pulled in through
py-python-meson, but without any version restrictions.Just add it as a direct dep with the bounds from https://github.com/scipy/scipy/blob/main/meson.build.