Skip to content

py-scipy: add lowerbound for meson version#3234

Merged
haampie merged 3 commits intodevelopfrom
hs/py-scipy/meson-lowerbound
Feb 10, 2026
Merged

py-scipy: add lowerbound for meson version#3234
haampie merged 3 commits intodevelopfrom
hs/py-scipy/meson-lowerbound

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Feb 3, 2026

Meson is pulled in through py-python-meson, but without any version restrictions.

Just add it as a direct dep with the bounds from https://github.com/scipy/scipy/blob/main/meson.build.

@adamjstewart
Copy link
Copy Markdown
Member

Seems fine with me. Can you add a # meson.build comment on the line before so I know which file to check when adding new versions?

@adamjstewart adamjstewart self-assigned this Feb 3, 2026
Signed-off-by: Harmen Stoppels <[email protected]>
Copy link
Copy Markdown
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Signed-off-by: Harmen Stoppels <[email protected]>
@spackbot-triage spackbot-triage bot requested a review from rgommers February 3, 2026 13:35
adamjstewart
adamjstewart previously approved these changes Feb 3, 2026
@adamjstewart
Copy link
Copy Markdown
Member

@eli-schwartz do you want to give this a quick review before I merge?

@eli-schwartz
Copy link
Copy Markdown
Contributor

eli-schwartz commented Feb 5, 2026

This seems reasonable to me. Although meson is depended on indirectly via py-meson-python, the version constraint is only a minimum "to ensure the build backend wiring is compatible". It is entirely normal for projects to depend on a newer version in meson.build.

Although pip install in an isolated build venv generally installs the latest version, and you can "get away with" not requiring a suitable version (probably), this is not reliable or robust when the version from an existing environment may be used, and users for example decide that they wish to upgrade scipy, and only scipy. Specifying the direct build constraints is therefore necessary in order to prevent build failures; this PR prevents build failures, so 👍

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Feb 5, 2026

Although pip install in an isolated build venv generally installs the latest version

Yup, this is what you get when you haven't bumped spack-packages in a while, and when spack reuses old stuff ;)

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Feb 5, 2026

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 5, 2026

I've started that pipeline for you!

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Feb 5, 2026

Apparently this change causes the tutorial pipeline to get stuck concretizing for 1h+, six times in a row :)

That should not be a blocker, it's just that that stack is configured incorrectly. So would suggest to force merge this after #3255 is closed.

@haampie haampie disabled auto-merge February 10, 2026 11:18
@haampie haampie merged commit 9365c21 into develop Feb 10, 2026
32 of 33 checks passed
@haampie haampie deleted the hs/py-scipy/meson-lowerbound branch February 10, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants