cprnc: use placement instead of destination for genf90 resource#2432
Merged
sethrj merged 2 commits intospack:developfrom Nov 15, 2025
Merged
cprnc: use placement instead of destination for genf90 resource#2432sethrj merged 2 commits intospack:developfrom
sethrj merged 2 commits intospack:developfrom
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/cprnc/package.py
repos/spack_repo/builtin/packages/estarlight/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
jedwards4b
approved these changes
Nov 14, 2025
sethrj
approved these changes
Nov 15, 2025
AlexanderRichert-NOAA
added a commit
to AlexanderRichert-NOAA/spack-packages
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR use placement instead of destination for the genf90 resource in cprnc. This seems to be the only way to consistently have the path of the resource be correctly set, especially when using cached source code.