mapl: add placement's for resources#2431
Merged
sethrj merged 1 commit intospack:developfrom Nov 15, 2025
Merged
Conversation
spackbot-triage
bot
requested review from
Hang-Lei-NOAA,
climbfuji,
edwardhartnett,
mathomp4 and
tclune
mathomp4
approved these changes
Nov 14, 2025
Contributor
mathomp4
left a comment
mathomp4
left a comment
There was a problem hiding this comment.
Interesting. I wonder why it was never needed until now? I mean, seems benign.
Contributor
Author
|
It relates to an issue with installing from source caching that I've never been totally consistently able to reproduce, so it's a bit of an edge case (most people most of the time install from internet-connected systems). In any case this seems to work solidly both with and without pre-cached resources. |
sethrj
approved these changes
Nov 15, 2025
AlexanderRichert-NOAA
added a commit
to AlexanderRichert-NOAA/spack-packages
that referenced
this pull request
Nov 19, 2025
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds placement arguments for the resources in mapl. This seems to be the only way to consistently have the path of the resource be correctly set, especially when using cached source code.