tutorial stack: use when_possible and bootstrap gcc12 (new container)#2277
Merged
tutorial stack: use when_possible and bootstrap gcc12 (new container)#2277
Conversation
…iner) Signed-off-by: Gregory Becker <[email protected]>
becker33
force-pushed
the
tutorial/bootstrap-gcc-for-tutorial
branch
from
5036572 to
2ec27f0
Compare
becker33
requested review from
alecbcs,
tgamblin and
tldahlgren
as code owners
Signed-off-by: Gregory Becker <[email protected]>
becker33
requested review from
kwryankrattiger and
zackgalbreath
as code owners
We add more padding for the package that is being built to better test package relocation. Change to key this package by name/hash instead of just name, for cases in which the package appears multiple times in the DAG (e.g. when bootstrapping one gcc with another). Signed-off-by: Gregory Becker <[email protected]>
Contributor
|
Looks good to me. Will approve when image tags are changed |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Member
Author
|
I had to get more specific than ideal with some of the specs to keep them distinct while using the |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Member
Author
|
@kwryankrattiger @alecbcs this should be ready to go now, and I've tested the entire tutorial with the PR buildcache that it generated -- may require some light tweaking to the stacks tutorial but overall I'm happy with it and getting back to having automation is good. |
zackgalbreath
approved these changes
Nov 12, 2025
psakievich
approved these changes
Nov 12, 2025
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
…spack#2277) * tutorial stack: use when_possible and bootstrap gcc12 (uses new container) Signed-off-by: Gregory Becker <[email protected]> * update generation container in addition to build container Signed-off-by: Gregory Becker <[email protected]> * fix padding for multiple-appearing package names We add more padding for the package that is being built to better test package relocation. Change to key this package by name/hash instead of just name, for cases in which the package appears multiple times in the DAG (e.g. when bootstrapping one gcc with another). Signed-off-by: Gregory Becker <[email protected]> * disable compiler mixing and lock down gcc runtimes Signed-off-by: Gregory Becker <[email protected]> * Be more specific to avoid when_possible confusion Signed-off-by: Gregory Becker <[email protected]> * update container to final hash post-merge Signed-off-by: Gregory Becker <[email protected]> * update to use main ref for container image Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Feb 5, 2026
…ntainer) (#2277)" This reverts commit 8d0701f. Signed-off-by: Gregory Becker <[email protected]>
alecbcs
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Revert "ci: disable tutorial pipeline (#3249)" * Revert "tutorial stack: use when_possible and bootstrap gcc12 (new container) (#2277)" This commit re-enables the tutorial stack without using `when_possible` which was leading to extremely long multi round concretization times post spack/spack#51796. Although this implementation of the tutorial stack is not technically correct when using compilers as nodes, it'll allow us to continue to ensure that all of the components of the stack build and are not accidentally broken due to a package PR. The long term solution here is to merge spack/spack#51891 which allows for multiple concretization groups in an environment and thus allows us to bootstrap a gcc compiler and then use it to build additional specs in the tutorial. --------- Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new container that doesn't have gcc-12 installed
Use
when_possibleto bootstrap the compiler from the container in a multi-round solve as @haampie pointed out is possible.