Merged
Conversation
4 tasks
climbfuji
added a commit
to JCSDA/spack-packages
that referenced
this pull request
Oct 28, 2025
Bug fixes for a number of packages required to build on DOD's HPCMP Narwhal. All of these bug fixes were submitted upstream: - ectrans: bug fix for finding lapack on cray - Bug fix in ectrans: use cmake to detect LAPACK libraries spack#1946 - py-kiwisolver: missing c dependency - Add missing dependency on c language in py-kiwisolver spack#1925 - py-cartopy: missing c dependency - py-cartopy: add missing dependency on c language spack#1944 - mct: add -fPIC flags - Build MCT with -fPIC spack#2138
alalazo
requested changes
Nov 4, 2025
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Since compilers are now packages, I suggest using the syntax below. The other interface is there to support legacy code.
Thanks @alalazo! Co-authored-by: Massimiliano Culpo <[email protected]>
climbfuji
commented
Nov 4, 2025
alalazo
approved these changes
Nov 4, 2025
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
Co-authored-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All in the title.
MCTis no longer developed and only supports static builds. In order to link the library to shared libraries, it needs-fPIC.Tested on my dev machine.