Skip to content

Bug fix in ectrans: use cmake to detect LAPACK libraries#1946

Merged
alalazo merged 4 commits intospack:developfrom
climbfuji:bugfix/ectrans_lapack_upstream
Oct 28, 2025
Merged

Bug fix in ectrans: use cmake to detect LAPACK libraries#1946
alalazo merged 4 commits intospack:developfrom
climbfuji:bugfix/ectrans_lapack_upstream

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji commented Oct 10, 2025

Description

Bug fix in ectrans: use cmake to detect LAPACK libraries unless MKL is requested explicitly, don't just go and look for cray-libsci.

See ecmwf-ifs/ectrans#316 for details.

Notes

  • I will be on leave Oct 11-20. Any feedback from the ectrans developers regarding the minimum cmake version required to support detecting LAPACK via cmake/ecbuild will be incorporated after my return.
  • I tested the PR as is (hash 7846a5f) on a system with cmake 3.31.8, and it correctly linked against the LAPACK provider from spack (openblas)
  • Update 2025/10/23: I tested this with [email protected] after hearing back from the ectrans developers that their most-recent release 1.7.0 requires [email protected].

…s requested explicitly, don't just go and look for cray-libsci
Comment thread repos/spack_repo/builtin/packages/ectrans/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/ectrans/package.py Outdated
@climbfuji climbfuji marked this pull request as ready for review October 23, 2025 20:46
@climbfuji climbfuji requested a review from tldahlgren October 23, 2025 20:48
@alalazo alalazo self-assigned this Oct 28, 2025
@alalazo alalazo merged commit 170bb42 into spack:develop Oct 28, 2025
17 checks passed
climbfuji added a commit to JCSDA/spack-packages that referenced this pull request Oct 28, 2025
Bug fixes for a number of packages required to build on DOD's HPCMP Narwhal. All of these bug fixes were submitted upstream:
- ectrans: bug fix for finding lapack on cray - Bug fix in ectrans: use cmake to detect LAPACK libraries spack#1946
- py-kiwisolver: missing c dependency - Add missing dependency on c language in py-kiwisolver spack#1925
- py-cartopy: missing c dependency - py-cartopy: add missing dependency on c language spack#1944
- mct: add -fPIC flags - Build MCT with -fPIC spack#2138
mkrack pushed a commit to mkrack/spack-packages that referenced this pull request Dec 23, 2025
@climbfuji climbfuji deleted the bugfix/ectrans_lapack_upstream branch January 23, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants