ESMF: workaround for legacy linking to MPI C++ interface#1856
Merged
tldahlgren merged 1 commit intospack:developfrom Oct 6, 2025
Merged
ESMF: workaround for legacy linking to MPI C++ interface#1856tldahlgren merged 1 commit intospack:developfrom
tldahlgren merged 1 commit intospack:developfrom
Conversation
…acy linking to MPI C++ interface
Contributor
|
A fix for this has been implemented upstream with https://github.com/esmf-org/esmf/releases/tag/v9.0.0b04 and later. As @climbfuji points out, this spack-packages PR is safe independent of ESMF version (with or without the upstream fix), therefore good to have! |
tldahlgren
approved these changes
Oct 6, 2025
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
…acy linking to MPI C++ interface (spack#1856)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
repos/spack_repo/builtin/packages/esmf/package.py: workaround for legacy linking to MPI C++ interface.A fix for this will be made upstream for newer versions of ESMF (release/beta snapshot unknown). The
filter_filefunction doesn't cause any harm if the search string can't be found, therefore not applying any version bounds to this patch.Issues
See esmf-org/esmf#497.
Testing
Tested on Navy DSRC Nautilus system that has the MPI C++ bindings installed.