Patch for building [email protected], [email protected], and [email protected]:2.61 with Intel oneAPI 2025.2; add [email protected]#1592
Merged
tldahlgren merged 13 commits intospack:developfrom Oct 9, 2025
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/yafyaml/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/yafyaml/package.py:73: [E501] line too long (104 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I've updated the branch with style fixes. |
climbfuji
commented
Sep 19, 2025
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/pflogger/package.py
repos/spack_repo/builtin/packages/yafyaml/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/pflogger/package.py:80: [E501] line too long (109 > 99 characters)
repos/spack_repo/builtin/packages/yafyaml/package.py:73: [E501] line too long (106 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I've updated the branch with style fixes. |
climbfuji
changed the title
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
climbfuji
changed the title
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/mapl/package.py
repos/spack_repo/builtin/packages/pflogger/package.py
repos/spack_repo/builtin/packages/quantum_espresso/package.py
repos/spack_repo/builtin/packages/yafyaml/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/mapl/package.py:435: [E501] line too long (154 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I've updated the branch with style fixes. |
Contributor
Author
|
@mathomp4 This is ready for your review. We may want to add version constraints and conflicts for mapl, similar to what I did for yafyaml and pflogger. |
Contributor
@climbfuji I'll try and test it today myself. In re MAPL, the biggest limit for versioning is from like 2.15 to 2.61. At least, that file only exists since then. But we already have: # MAPL can use ifx only from MAPL 2.51 onwards and only supports
# ifx 2025.0 and newer due to bugs in ifx.
conflicts("^[virtuals=fortran] intel-oneapi-compilers@2025:", when="@:2.50")so maybe we just say your in-spack workaround is usable from 2.51 to 2.61? Hopefully with 2.62 we'll have the fixes necessary internally. |
climbfuji
changed the title
climbfuji
changed the title
Contributor
Author
|
@mathomp4 This is ready! |
mathomp4
approved these changes
Sep 26, 2025
tldahlgren
requested review from
AlexanderRichert-NOAA,
Hang-Lei-NOAA,
edwardhartnett and
tclune
Contributor
|
FYI. Added missing maintainers (especially from |
tldahlgren
approved these changes
Oct 9, 2025
mathomp4
approved these changes
Oct 9, 2025
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
… with Intel oneAPI 2025.2; add [email protected] (spack#1592) * Bug fix for Intel oneAPI 2025.2 that allows building [email protected] * [@spackbot] updating style on behalf of climbfuji * Use 'for' to apply patch in repos/spack_repo/builtin/packages/yafyaml/package.py * Patch for building [email protected] with [email protected] * [@spackbot] updating style on behalf of climbfuji * Patch for building mapl with [email protected] * [@spackbot] updating style on behalf of climbfuji * Add [email protected], and constrain workaround for [email protected] to @:2.61 --------- Co-authored-by: climbfuji <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Intel oneAPI 2025.2 Fortran preprocessor has a bug that was reported in https://community.intel.com/t5/Intel-Fortran-Compiler/Regression-with-fpp-2025-2-0/td-p/1703735 as well as in an internal premier support ticket. Intel fixed this in their developmental code, and the bug fix will be in Intel oneAPI 2026.
This patch allows building [email protected] and [email protected] with that compiler, as well as a range of recent
maplversions@2.51:2.61(I tested@2.53). The lower limit is due to the general conflict ofmapl@:2.50with Intel oneAPI, the upper bound is because 2.62.0, added here, contains the bug fixes for Intel oneAPI 2025.2.I restricted the patch to versions 1.5.1/1.16.1 of yafyaml/pflogger because (a) I don't want to try if the patch works for the older versions, and (b) the package maintainer @mathomp4 and I had a conversation, and we will try to add this patch to the authoritative code base for later versions of yafyaml and pflogger.
I tested this on my local machine with [email protected].