Skip to content

py-jupyterlab-server: add the "build-tools" tag#1078

Merged
alalazo merged 2 commits intospack:developfrom
alalazo:fixes/pythological-package-not-concretizing
Aug 13, 2025
Merged

py-jupyterlab-server: add the "build-tools" tag#1078
alalazo merged 2 commits intospack:developfrom
alalazo:fixes/pythological-package-not-concretizing

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Aug 13, 2025

refers spack/spack#51134

This identifies the package as possibly needing more than one node in a DAG, due to conflicting build constraints of other packages

This identifies the package as possibly needing more than
one node in a DAG, due to conflicting build constraints of
other packages

Signed-off-by: Massimiliano Culpo <[email protected]>
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Aug 13, 2025

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 13, 2025

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 13, 2025

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/libint/package.py
repos/spack_repo/builtin/packages/py_jupyterlab_server/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/py_jupyterlab_server/package.py:21: [W293] blank line contains whitespace
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will now apply to build/run deps of build deps?

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Aug 13, 2025

This potentially allows the package to have its own unification set, and to have multiple nodes. It depends on the configuration values of the concretizer section.

@alalazo alalazo merged commit 9ca712a into spack:develop Aug 13, 2025
17 checks passed
@alalazo alalazo deleted the fixes/pythological-package-not-concretizing branch August 13, 2025 15:24
mladenivkovic pushed a commit to mladenivkovic/spack-packages that referenced this pull request Aug 31, 2025
This identifies the package as possibly needing more than
one node in a DAG, due to conflicting build constraints of
other packages

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants