Merged
Conversation
alalazo
reviewed
Dec 4, 2018
Contributor
|
Aside from the travis checks, I'm all good with this. If you're willing, it might be nice to have a "current" or "head" target on it, but that would just be a help since it would knock a to-do off the list for the package. Thanks for putting this together! |
trws
approved these changes
Dec 5, 2018
Member
I just restarted the failed build (which of course has nothing to do with the PR). Lately we have experienced frequent CI failures due to |
alalazo
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9301
Fixes #7184