SEACAS: Add preliminary support for seacas package#9972
Merged
adamjstewart merged 13 commits intospack:developfrom Dec 17, 2018
Merged
SEACAS: Add preliminary support for seacas package#9972adamjstewart merged 13 commits intospack:developfrom
adamjstewart merged 13 commits intospack:developfrom
Conversation
adamjstewart
requested changes
Nov 29, 2018
* Add PLASMA 18.11.1 with optional Lua and test for headers
* py-jupyter-console: Add version 5.2.0 * py-jupyter-core: add version 4.4.0 * py-lxml: add version 4.2.5 * py-zmq: add version 17.1.2 * py-terminado: add version 0.8.1 * py-pexpect: add version 4.6.0 * py-pytables: add version 3.4.4
Instead of using an `allpkgs` or explicitly specifying each individual subset, changed to minimize variants: * By default, the exodus and IOSS libraries are built and a few executables directly related to the IOSS library. * variant `common` defaults to True and builds the "common" seacas applications. This is based on my definition, so there may be could be some discussion on what belongs here. * variant `legacy` defaults to True and builds the remainder of the seacas applications. These are still used, but mainly in more esoteric areas. Might be better to default to False, but I wanted default to just build everything which is what other SEACAS builds always do... Removed the `kokkos` variants for now as I need to do some more thinking on how best to support this. Not often used currently, so shouldn't be an issue. Cleaned up other issues raised by Adam and found by me.
Contributor
Author
|
@adamjstewart I think all requested changes have been addressed. |
Fixed package variant logic. Consolidated some other variant handling logic Other minor refactors for hopefully better readability
Missing whitespace around operator fixed.
Contributor
Author
|
@adamjstewart I think all requested changes have been made. Thanks for the feedback, I think it is a much better package than it started out to be. Let me know if anything else needed to get it merged. |
adamjstewart
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the SEACAS package from Sandia. Contains the exodus library (aka exodusII) and several applications which can create, modify, query, translate exodus files. Also includes IOSS library and the aprepro library and application. Documentation at http://gsjaardema.github.io/seacas/
Several variants are available, but not all have yet been tested. I have tested the default allpkgs build with and without mpi and that seems to be working correctly.
Best current version of SEACAS source code is the
developbranch on github. I hope to have better versioning soon...