GDL: python integration fixes#9936
Merged
adamjstewart merged 4 commits intospack:developfrom Dec 17, 2018
Merged
Conversation
Contributor
rmsds
commented
Nov 23, 2018
rmsds
commented
- renamed python-related variants to follow the convention
- building the Python module requires patches currently targetting 0.9.8 othwerwise asking for the Python module only builds the Pyhton module
- building the python module also requires patching the vendored (with the GDL) antlr to be built as a shared library
* renamed python-related variants to follow the convention * building the Python module requires patches currently targetting 0.9.8 othwerwise asking for the Python module *only* builds the Pyhton module * building the python module also requires patching the vendored (with the GDL) antlr to be built as a shared library
adamjstewart
requested changes
Nov 24, 2018
Member
Contributor
Author
|
@adamjstewart implemented the changes you requested. The tests are still failing but I don't think there's anything i can do about that. |
adamjstewart
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.