Merged
Conversation
Member
michaelkuhn
commented
Nov 9, 2018
michaelkuhn
commented
- Add 1.85
- OPENSSL_PREFIX has to be set in the environment, otherwise Spack's openssl will not be found
- Add 1.85 - OPENSSL_PREFIX has to be set in the environment, otherwise Spack's openssl will not be found
healther
reviewed
Nov 12, 2018
| inspect.getmodule(self).perl('Makefile.PL', 'INSTALL_BASE={0}'. | ||
| format(prefix), 'OPENSSL_PREFIX=%s' % | ||
| self.spec['openssl'].prefix, input=f) | ||
| format(prefix), input=f) |
Contributor
There was a problem hiding this comment.
Did this work before? Can INSTALL_BASE also be supplied via the environment?
Member
Author
There was a problem hiding this comment.
I am guessing it did not and just picked up the globally installed OpenSSL.
INSTALL_BASE seems to be a proper MakeMaker variable and it supposed to be passed to the Makefile, see: https://perldoc.perl.org/ExtUtils/MakeMaker.html
healther
approved these changes
Nov 12, 2018
adamjstewart
approved these changes
Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.