Merged
Conversation
healther
suggested changes
Nov 12, 2018
Contributor
healther
left a comment
healther
left a comment
There was a problem hiding this comment.
can you add conflicts for the versions you know that dont build with gcc@8?
Needed to compile with gcc@8 and recent versions of glibc.
michaelkuhn
force-pushed
the
nginx-1.15.6
branch
from
4ad295e to
0633167
Compare
Member
Author
I could not find the exact version that starts building with gcc@8 but I have added a conflicts that covers all versions we have in Spack. |
healther
approved these changes
Nov 12, 2018
healther
reviewed
Nov 12, 2018
| depends_on('pcre') | ||
| depends_on('zlib') | ||
|
|
||
| conflicts('%gcc@8:', when='@:1.14') |
Contributor
There was a problem hiding this comment.
there is a msg attribute, you could use it to document that this is based on "all spack knows" rather than on "that's what they claim", but no strong opinions
Member
Author
There was a problem hiding this comment.
I just checked out the nginx source again and the fix is not on the 1.14 branch but in 1.15.0, so this conflicts should actually be correct. :-)
adamjstewart
approved these changes
Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to compile with gcc@8.