Allow build caches for packages with broken symlinks#9733
Closed
scheibelp wants to merge 1 commit intospack:developfrom
Closed
Allow build caches for packages with broken symlinks#9733scheibelp wants to merge 1 commit intospack:developfrom
scheibelp wants to merge 1 commit intospack:developfrom
Conversation
… on them, as it will fail; print a warning instead
Member
Author
healther
reviewed
Nov 6, 2018
| dirs[:] = [d for d in dirs if d not in blacklist] | ||
| for filename in files: | ||
| path_name = os.path.join(root, filename) | ||
| try: |
Contributor
There was a problem hiding this comment.
you should probably add why this extra handling is warranted
Member
Author
|
There are other efforts to fix the symlinks etc. so I don't think this is the best approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a package install generates broken symlinks, avoid doing a 'strings' check on them, as it will fail; print a warning instead
At some level this addresses a symptom rather than a cause: should package be considered installed by Spack if it contains broken symlinks? Probably not.