Delete references to ruamel.yaml at Spack start-up, if they are present#9725
Merged
tgamblin merged 2 commits intospack:developfrom Nov 7, 2018
Merged
Conversation
fixes spack#9206 ruamel.yaml generates a .pth file when installed via pip that has the effect of always preferring the version of this package installed at site scope (effectively preventing us from vendoring it). This mechanism triggers when implicitly importing the 'site' module when the python interpreter is started. In this PR we explicitly delete references to 'ruamel.yaml' and 'ruamel' in sys.modules, if any, after we set 'sys.path' to search from the directory where we store vendored packages. This ensures that the imports after those statements will be done from our vendored version.
Member
Author
This was referenced Nov 5, 2018
Member
|
Works for me, thanks a lot! :) |
ax3l
approved these changes
Nov 5, 2018
tgamblin
requested changes
Nov 5, 2018
healther
approved these changes
Nov 6, 2018
ax3l
approved these changes
Nov 6, 2018
Member
Author
|
@tgamblin done |
tgamblin
approved these changes
Nov 7, 2018
Member
|
@alalazo: thanks! |
Member
|
@alalazo thanks a lot again!! 🚀 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9619
fixes #9206
closes #9702 (alternative solution to the same issue)
closes #9261 (alternative solution to the same issue)
ruamel.yamlgenerates a.pthfile when installed via pip that has the effect of always preferring the version of this package installed at site scope (effectively preventing us from vendoring it).This mechanism triggers when implicitly importing the
sitemodule when the python interpreter is started. In this PR we explicitly delete references toruamel.yamlandruamelinsys.modules, if any, after we setsys.pathto search from the directory where we store vendored packages. This ensures that the imports after those statements will be done from our vendored version.