Skip to content

added r-bindr v 0.1.1#9717

Merged
adamjstewart merged 1 commit intospack:developfrom
ifelsefi:develop
Nov 13, 2018
Merged

added r-bindr v 0.1.1#9717
adamjstewart merged 1 commit intospack:developfrom
ifelsefi:develop

Conversation

@ifelsefi
Copy link
Copy Markdown
Contributor

@ifelsefi ifelsefi commented Nov 2, 2018

No description provided.

Copy link
Copy Markdown
Contributor

@healther healther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide the sha256 hash rather than the md5?

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely good to use sha256 by default, but at some point we plan on automatically updating the hashes for every version of every package. Merging this as is for the sake of reducing the number of open PRs.

@adamjstewart adamjstewart merged commit ab48a96 into spack:develop Nov 13, 2018
@ifelsefi
Copy link
Copy Markdown
Contributor Author

Thanks @adamjstewart

The default is still md5. Would be nice if that was changed to sha256.

@healther
Copy link
Copy Markdown
Contributor

What do you mean by default?

@ifelsefi
Copy link
Copy Markdown
Contributor Author

Spack showed checksum error when I added the new URL for updated package. The error printed MD5 hash of package which was found vs expected hash.

@adamjstewart
Copy link
Copy Markdown
Member

If your hash is an MD5 hash, Spack will print the found vs expected MD5 hash. If your hash is a sha256 hash, Spack will print the found vs expected sha256 hash. The default if you use spack checksum or spack create is to use sha256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants