The vendored ruamel.yaml is imported under the namespace 'external'#9702
Closed
alalazo wants to merge 1 commit intospack:developfrom
Closed
The vendored ruamel.yaml is imported under the namespace 'external'#9702alalazo wants to merge 1 commit intospack:developfrom
alalazo wants to merge 1 commit intospack:developfrom
Conversation
fixes spack#9206 ruamel.yaml generates a .pth file when installed via pip that has the effect of always preferring the version of this package installed at site scope (effectively preventing us from vendoring it). Here we work around the issue by putting our vendored version of the package under an additional namespace.
Member
|
@alalazo: can we really not do this using |
tgamblin
requested changes
Nov 2, 2018
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
See above -- I'd really rather do this by tweaking sys.modules, but if that isn't possible this may have to do.
Member
Author
|
@tgamblin I'll try tweaking |
Member
|
@alalazo: thanks! Sorry if I was misleading -- I thought I mentioned this earlier but @scheibelp pointed out I probably should've been more emphatic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9619
fixes #9206
closes #9261 (alternative solution to the same issue)
closes #9725 (alternative solution to the same issue)
ruamel.yamlgenerates a.pthfile when installed via pip that has the effect of always preferring the version of this package installed at site scope (effectively preventing us from vendoring it). Here we work around the issue by putting our vendored version of the package under an additional namespace.Note that we do this only for
ruamel.yamlrather than consistently for every vendored dependency to avoid extensive changes in their source code, see #9206 (comment)