Skip to content

henson: new package#9657

Merged
ax3l merged 5 commits intospack:developfrom
mrzv:package/henson
Nov 1, 2018
Merged

henson: new package#9657
ax3l merged 5 commits intospack:developfrom
mrzv:package/henson

Conversation

@mrzv
Copy link
Copy Markdown
Contributor

@mrzv mrzv commented Oct 27, 2018

Henson is a tool for in situ processing, using cooperative multitasking.

extends('python', when='+python')
variant('mpi-wrappers', default=True, description= 'Build MPI wrappers (PMPI)')

conflicts('^openmpi', when='+mpi-wrappers')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to add a comment which MPI flavors are supported if the spack-default (OpenMPI) is not?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPICH works fine in all configurations. OpenMPI is supported, just not with mpi-wrappers=True. What's the right solution here? Turn mpi-wrappers off, by default? Is there a way to express default preference for MPICH?

Copy link
Copy Markdown
Member

@ax3l ax3l Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since OpenMPI is by default one it will be easier for users to default the mpi-wrappers variant to False indeed.

Is there a way to express default preference for MPICH?

Pew, let me ask this in Slack, I don't know. But I think there is no way to express this here since those defaults are usually set in packages.yaml config files.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like one can express this currently while still keeping the virtual package dependency on mpi.

url = "https://github.com/henson-insitu/henson"
git = "https://github.com/henson-insitu/henson.git"

version('master', branch='master')
Copy link
Copy Markdown
Member

@ax3l ax3l Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this your development branch? If so, you can use the spack reserved version name develop here :)

order of versions is (newest to oldest)

develop
2.3.4 (default)
1.2.3
any-other

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really the only version right now. So I guess it counts as the development version. I'll rename it to develop.

@ax3l ax3l merged commit 36ddcc2 into spack:develop Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants