netcdf-fortran: add LDFLAGS to fix contents of libnetcdff.la.#9647
Merged
scheibelp merged 1 commit intospack:developfrom Nov 14, 2018
Merged
netcdf-fortran: add LDFLAGS to fix contents of libnetcdff.la.#9647scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
alalazo
approved these changes
Oct 29, 2018
Member
|
@skosukhin this has conflicts now that #9605 has been merged - can you update this? |
skosukhin
force-pushed
the
netcdf-fortran
branch
from
ce32a53 to
be0f492
Compare
Member
Author
|
@scheibelp done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to specify
LDFLAGSto get correctdependency_libsinlibnetcdff.la, so packages that uselibtoolfor linking could correctly link to all the dependencies even when the building takes place outside of Spack environment, i.e. without Spack's compiler wrappers.