Skip to content

Add 'pic' variant to netcdf packages#9605

Merged
scheibelp merged 7 commits intospack:developfrom
bebosudo:bebosudo_fix_netcdf_pic
Nov 13, 2018
Merged

Add 'pic' variant to netcdf packages#9605
scheibelp merged 7 commits intospack:developfrom
bebosudo:bebosudo_fix_netcdf_pic

Conversation

@bebosudo
Copy link
Copy Markdown
Contributor

No description provided.

@bebosudo
Copy link
Copy Markdown
Contributor Author

@davydden 3fb3077 should fix it.

@bebosudo
Copy link
Copy Markdown
Contributor Author

bebosudo commented Oct 26, 2018

Hi @scheibelp, I used your suggestion and moved building flags setup into the flags_handler method.

I didn't touch anything inside the netcdf package, because there are lots of components.
If we want to edit it as well, should we just move all the *flags.append() into a flag_handler method, and leave there only the actual configure args?

@scheibelp scheibelp merged commit c7c3fab into spack:develop Nov 13, 2018
@bebosudo bebosudo deleted the bebosudo_fix_netcdf_pic branch November 14, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants