Skip to content

pfunit: add mpi-test patch#9387

Merged
junghans merged 4 commits intodevelopfrom
packages/pfunit
Dec 5, 2018
Merged

pfunit: add mpi-test patch#9387
junghans merged 4 commits intodevelopfrom
packages/pfunit

Conversation

@junghans
Copy link
Copy Markdown
Contributor

@cferenba
Copy link
Copy Markdown
Contributor

cferenba commented Oct 1, 2018

@junghans : If this is going into the main spack repo, we need to better document what it does; but I can't tell what's the best way to do that - any suggestions?

@junghans
Copy link
Copy Markdown
Contributor Author

junghans commented Oct 1, 2018

@cferenba Can you write a blurb of documentation for that patch please?

@cferenba
Copy link
Copy Markdown
Contributor

Blurb:
"This patch modifies pfunit to be usable by codes that have MPI_COMM_WORLD hardcoded as their communicator, by skipping over any tests whose PE count does not match the size of the current MPI_COMM_WORLD."

Along with this, I'd recommend renaming the patch to mpi_comm_world.patch, and the variant to something like use-comm-world.

@junghans junghans requested a review from adamjstewart December 3, 2018 22:16
@adamjstewart adamjstewart added tests General test capability(ies) mpi patch labels Dec 4, 2018
@junghans
Copy link
Copy Markdown
Contributor Author

junghans commented Dec 5, 2018

/cc @JohnWGrove

@junghans junghans merged commit d149ab6 into develop Dec 5, 2018
@junghans junghans deleted the packages/pfunit branch December 5, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants