Merged
Conversation
davydden
force-pushed
the
features/unit_tests
branch
2 times, most recently
from
669d379 to
d13098d
Compare
davydden
force-pushed
the
features/unit_tests
branch
from
d13098d to
eba264f
Compare
Member
Author
|
don't understand why coverage decreased as I documented the functions I introduce. |
Member
|
@davydden that's because you added code in FYI coverage is computed only on source files under |
Member
Author
|
i don't know how to add tests 😄 |
Member
Author
|
but I can certainly add a |
Member
|
@davydden: I think we'll be ok with a 0.1% loss in coverage 😄. If you want to add a test I think it would be ok, but we could also just build openblas or another representative package as part of the travis runs. That might be an easier way to go. |
olupton
pushed a commit
to olupton/spack
that referenced
this pull request
Feb 7, 2022
olupton
pushed a commit
to olupton/spack
that referenced
this pull request
Feb 7, 2022
* Update bbp-packages.yaml Adding my currentscape module to bbp-packages. * Update modules.yaml Adding my currentscape package to the whitelist. * Create package.py Added my currentscape package. * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update package.py Modified the version. Is it better now? * update bglibpy to 4.4.6 (spack#937) * Update package.py Changing tag to match the one from source on gerrit. * Bglibpy 4.4.10 (spack#938) * update bglibpy to 4.4.6 * updated to bglpy 4.4.10 v 4.4.10 does not have the pandas, pyrsistent or the bluepy-configfile dependencies * Updates Libsonata package to include readers improvements (spack#940) * update glm to 0.9.9.3 (spack#943) * Bump neurodamus for most recent patches (spack#942) Bump neurodamus-py 2.0.0 to 2.0.2: - Fixing replay to work with multiple populations - Ensure data dir when skipping model build - Fix skipping synapse creation when weight is 0 (BBPBGLIB-673) - Fix deadlock when an exception is thrown from NEURON (BBPBGLIB-678) - Logging colors only for tty Bump neurodamus-core 3.0.0 to 3.0.1: - Avoid getting nilSecRef from objects (HPCTM-1381) * Update py-sonata-network-reduction dependencies: [email protected], [email protected] (spack#930) * Update bbp-packages.yaml Updated currentscape version. * Update package.py Updated version & tag. * Brion and Brayns are dependent on GLM (spack#944) * Steps updates (spack#941) * gmsh: add version 4.6.0 * omega-h: new version 9.32.5.dev3 * steps: new test requirements * libsonata-report: Improves initialization performance (spack#945) * adapt brion test to a new python module name (spack#946) * Adding nvidia-hpc-sdk based on upstream PR (spack#935) * New compiler: nvhpc (NVIDIA HPC SDK) (spack#19294) * Add nvhpc compiler definition: "spack compiler add" will now look for instances of the NVIDIA HPC SDK compiler executables (nvc, nvc++, nvfortran) in supplied paths * Add the nvhpc package which installs the nvhpc compiler * Add testing for nvhpc detection and C++-standard/pic flags Based on spack#19294 * Add CUDA@11 required for latest NVIDIA-HPC-SDK * Fix legacy apis : setup_environment to setup_run_environment * NEURON and CoreNEURON should use legacy units for BBP/HBP deployment (spack#947) * Update bbp-packages.yaml Adding my currentscape module to bbp-packages. * Update modules.yaml Adding my currentscape package to the whitelist. * Create package.py Added my currentscape package. * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update var/spack/repos/builtin/packages/py-currentscape/package.py Co-authored-by: Matthias Wolf <[email protected]> * Update package.py Modified the version. Is it better now? * Update package.py Changing tag to match the one from source on gerrit. * Update bbp-packages.yaml Updated currentscape version. * Update package.py Updated version & tag. Co-authored-by: Matthias Wolf <[email protected]> Co-authored-by: anilbey <[email protected]> Co-authored-by: Sergio <[email protected]> Co-authored-by: ppodhajski <[email protected]> Co-authored-by: Fernando Pereira <[email protected]> Co-authored-by: asanin-epfl <[email protected]> Co-authored-by: Nadir Román Guerrero <[email protected]> Co-authored-by: Tristan Carel <[email protected]> Co-authored-by: Pramod Kumbhar <[email protected]> Co-authored-by: Jaquier Aurélien Tristan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per discussion in #812
@tgamblin @eschnett @alalazo ping.