Skip to content

Improve error message for wrong config section names#936

Merged
tgamblin merged 1 commit intospack:developfrom
hegner:bugfix/configsections
May 11, 2016
Merged

Improve error message for wrong config section names#936
tgamblin merged 1 commit intospack:developfrom
hegner:bugfix/configsections

Conversation

@hegner
Copy link
Copy Markdown

@hegner hegner commented May 11, 2016

Changes the behaviour towards invalid calls like spack config edit notExisting to

==> Error: Invalid config section: 'notExisting'. Options are: repos mirrors modules packages compilers

instead of

Traceback (most recent call last):
  File "/Users/hegner/spack/bin/spack", line 176, in <module>
    main()
  File "/Users/hegner/spack/bin/spack", line 154, in main
    return_val = command(parser, args)
  File "/Users/hegner/spack/lib/spack/spack/cmd/config.py", line 69, in config
    action[args.config_command](args)
  File "/Users/hegner/spack/lib/spack/spack/cmd/config.py", line 62, in config_edit
    config_file = spack.config.get_config_filename(args.scope, args.section)
  File "/Users/hegner/spack/lib/spack/spack/config.py", line 526, in get_config_filename
    return scope.get_section_filename(section)
  File "/Users/hegner/spack/lib/spack/spack/config.py", line 348, in get_section_filename
    validate_section_name(section)
  File "/Users/hegner/spack/lib/spack/spack/config.py", line 275, in validate_section_name
    % (section, section_schemas))
ValueError: Invalid config section: 'notExisting'.  Options are {'repos': {'additionalProperties': False, 'patternProperties': {'repos:?': {'default': [], 'items': {'type': 'string'}, 'type': 'array'}}, '$schema': 'http://json-schema.org/schema#', 'type': 'object', 'title': 'Spack repository configuration file schema'}, 'mirrors': {'additionalProperties': False, 'patternProperties': {'mirrors:?': {'default': {}, 'additionalProperties': False, 'patternProperties': {'\\w[\\w-]*': {'type': 'string'}}, 'type': 'object'}}, '$schema': 'http://json-schema.org/schema#', 'type': 'object', 'title': 'Spack mirror configuration file schema'}, 'modules': {'additionalProperties': False, 'patternProperties': {'modules:?': {'default': {}, 'additionalProperties': False, 'type': 'object', 'properties': {'enable': {'default': [], 'items': {'type': 'string'}, 'type': 'array'}}}}, '$schema': 'http://json-schema.org/schema#', 'type': 'object', 'title': 'Spack module file configuration file schema'}, 'packages': {'additionalProperties': False, 'patternProperties': {'packages:?': {'default': {}, 'additionalProperties': False, 'patternProperties': {'\\w[\\w-]*': {'default': {}, 'additionalProperties': False, 'type': 'object', 'properties': {'buildable': {'default': True, 'type': 'boolean'}, 'paths': {'default': {}, 'type': 'object'}, 'version': {'default': [], 'items': {'anyOf': [{'type': 'string'}, {'type': 'number'}]}, 'type': 'array'}, 'providers': {'default': {}, 'additionalProperties': False, 'patternProperties': {'\\w[\\w-]*': {'default': [], 'items': {'type': 'string'}, 'type': 'array'}}, 'type': 'object'}, 'compiler': {'default': [], 'items': {'type': 'string'}, 'type': 'array'}}}}, 'type': 'object'}}, '$schema': 'http://json-schema.org/schema#', 'type': 'object', 'title': 'Spack package configuration file schema'}, 'compilers': {'additionalProperties': False, 'patternProperties': {'compilers:?': {'default': {}, 'additionalProperties': False, 'patternProperties': {'\\w[\\w-]*': {'additionalProperties': False, 'patternProperties': {'\\w[\\w-]*@\\w[\\w-]*': {'additionalProperties': False, 'required': ['cc', 'cxx', 'f77', 'fc'], 'type': 'object', 'properties': {'cc': {'anyOf': [{'type': 'string'}, {'type': 'null'}]}, 'cxx': {'anyOf': [{'type': 'string'}, {'type': 'null'}]}, 'f77': {'anyOf': [{'type': 'string'}, {'type': 'null'}]}, 'fc': {'anyOf': [{'type': 'string'}, {'type': 'null'}]}}}}, 'type': 'object'}}, 'type': 'object'}}, '$schema': 'http://json-schema.org/schema#', 'type': 'object', 'title': 'Spack compiler configuration file schema'}}

@tgamblin tgamblin merged commit eaf046c into spack:develop May 11, 2016
@hegner hegner deleted the bugfix/configsections branch November 28, 2016 20:09
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
@AurelienJaquier @matz-e
@anilbey @sergiorg-hpc @ppodhajski @ferdonline @asanin-epfl @NadirRoGue @pramodk
py-currentscape: deploy and generate module (spack#936)
967c78d 
* Update bbp-packages.yaml

Adding my currentscape module to bbp-packages.

* Update modules.yaml

Adding my currentscape package to the whitelist.

* Create package.py

Added my currentscape package.

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update package.py

Modified the version. Is it better now?

* update bglibpy to 4.4.6 (spack#937)

* Update package.py

Changing tag to match the one from source on gerrit.

* Bglibpy 4.4.10 (spack#938)

* update bglibpy to 4.4.6

* updated to bglpy 4.4.10

v 4.4.10 does not have the pandas, pyrsistent or the bluepy-configfile dependencies

* Updates Libsonata package to include readers improvements (spack#940)

* update glm to 0.9.9.3 (spack#943)

* Bump neurodamus for most recent patches (spack#942)

Bump neurodamus-py 2.0.0 to 2.0.2:
 - Fixing replay to work with multiple populations
 - Ensure data dir when skipping model build
 - Fix skipping synapse creation when weight is 0 (BBPBGLIB-673)
 - Fix deadlock when an exception is thrown from NEURON (BBPBGLIB-678)
 - Logging colors only for tty

Bump neurodamus-core 3.0.0 to 3.0.1:
 - Avoid getting nilSecRef from objects (HPCTM-1381)

* Update py-sonata-network-reduction dependencies: [email protected], [email protected] (spack#930)

* Update bbp-packages.yaml

Updated currentscape version.

* Update package.py

Updated version & tag.

* Brion and Brayns are dependent on GLM (spack#944)

* Steps updates (spack#941)

* gmsh: add version 4.6.0
* omega-h: new version 9.32.5.dev3
* steps: new test requirements

* libsonata-report: Improves initialization performance (spack#945)

* adapt brion test to a new python module name (spack#946)

* Adding nvidia-hpc-sdk based on upstream PR (spack#935)

* New compiler: nvhpc (NVIDIA HPC SDK) (spack#19294)
* Add nvhpc compiler definition: "spack compiler add" will now look
  for instances of the NVIDIA HPC SDK compiler executables
  (nvc, nvc++, nvfortran) in supplied paths
* Add the nvhpc package which installs the nvhpc compiler
* Add testing for nvhpc detection and C++-standard/pic flags

Based on spack#19294

* Add CUDA@11 required for latest NVIDIA-HPC-SDK
* Fix legacy apis : setup_environment to setup_run_environment

* NEURON and CoreNEURON should use legacy units for BBP/HBP deployment (spack#947)

* Update bbp-packages.yaml

Adding my currentscape module to bbp-packages.

* Update modules.yaml

Adding my currentscape package to the whitelist.

* Create package.py

Added my currentscape package.

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update var/spack/repos/builtin/packages/py-currentscape/package.py

Co-authored-by: Matthias Wolf <[email protected]>

* Update package.py

Modified the version. Is it better now?

* Update package.py

Changing tag to match the one from source on gerrit.

* Update bbp-packages.yaml

Updated currentscape version.

* Update package.py

Updated version & tag.

Co-authored-by: Matthias Wolf <[email protected]>
Co-authored-by: anilbey <[email protected]>
Co-authored-by: Sergio <[email protected]>
Co-authored-by: ppodhajski <[email protected]>
Co-authored-by: Fernando Pereira <[email protected]>
Co-authored-by: asanin-epfl <[email protected]>
Co-authored-by: Nadir Román Guerrero <[email protected]>
Co-authored-by: Tristan Carel <[email protected]>
Co-authored-by: Pramod Kumbhar <[email protected]>
Co-authored-by: Jaquier Aurélien Tristan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hegner @tgamblin