Skip to content

added py-matplotlib version 3.0.0#9335

Merged
scheibelp merged 1 commit intodevelopfrom
packages/matplotlib-3.0.0
Oct 2, 2018
Merged

added py-matplotlib version 3.0.0#9335
scheibelp merged 1 commit intodevelopfrom
packages/matplotlib-3.0.0

Conversation

@lee218llnl
Copy link
Copy Markdown
Contributor

Matplotlib 3.0+ does not support Python 2.x, 3.0, 3.1, 3.2, 3.3, or 3.4.
Beginning with Matplotlib 3.0, Python 3.5 and above is required.

@adamjstewart
Copy link
Copy Markdown
Member

Wondering how this affects concretization since Python 2 is the default in Spack.

@lee218llnl
Copy link
Copy Markdown
Contributor Author

You have to explicitly specify ^[email protected]:, otherwise you will get:

py-matplotlib requires python version 3.5:, but spec asked for 2.7.15

Could we perhaps allow a depends_on to override the "preferred=True"?

@adamjstewart
Copy link
Copy Markdown
Member

Could we perhaps allow a depends_on to override the "preferred=True"?

That would definitely be the preferred behavior. Not sure how much work would be required to make that happen. @tgamblin @scheibelp?

Any thoughts on when we want to make Python 3 the default? How many Python 2-only packages remain?

@tgamblin
Copy link
Copy Markdown
Member

We should really be able to have packages depend on python 2/3/either when at different versions. Lemme think about this one. Is there a decent workaround you could use for right now?

@healther
Copy link
Copy Markdown
Contributor

Maybe we could remove the preferred=True from [email protected] and instead ship a packages_python27.yaml, which could take everything that is incompatible with py3 (but we will probably add to this over the next month or two)

@lee218llnl
Copy link
Copy Markdown
Contributor Author

I don't think we've come to any conclusion on this one. Could we merge it as is with the caveat that users need to explicitly specify ^[email protected]: and then work on a solution in a separate issue/PR?

@scheibelp scheibelp merged commit 676b3b0 into develop Oct 2, 2018
@scheibelp
Copy link
Copy Markdown
Member

Could we merge it as is with the caveat that users need to explicitly specify ^[email protected]: and then work on a solution in a separate issue/PR?

Agreed - thanks!

ptbremer pushed a commit to ptbremer/spack that referenced this pull request Oct 12, 2018
@tgamblin tgamblin deleted the packages/matplotlib-3.0.0 branch April 18, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants