@tgamblin Do we need a finer control than this ?

@alalazo: I wish I could ignore E501 only for lines starting with r'^\s*url\s*='. I am not sure if we can get that level of control.

@tgamblin I don't think we can do something like that out of the box. Don't know if we want to give a try at this or write something similar within spack...

Coverage increased (+0.004%) to 63.167% when pulling 7d74e20 on epfl-scitas:differentiate_framework_from_packages into 3e71784 on LLNL:develop.

@tgamblin @alalazo I believe you'd like to add [E241] multiple spaces after ',' to the exceptions as well.

@hegner Personally I don't mind having E241 on, but I think style management is really up to @tgamblin

I personally wouldn't like enforcing [E241] multiple spaces after ',' as I'm a big fan of lining things up. It might be the only thing in PEP8 that I disagree with.

Let's disable E241 -- I'm not a stickler for it but I occasionally like things lined up.

@alalazo: what if we run this on package files before running flake8:

perl -i~ -pe 's/^(\s*url\s*=.*)$/\1 # NOQA/' */package.py

That would auto-NOQA the URLs.

@tgamblin I think the approach above is worth a try for URLs. I'll try to do my best to help people stuck with flake8 checks in the meanwhile...

BTW, I set up this PR just because I thought it would have been clearer and faster to show case a code diff than to explain the modifications in words. If you think we don't need two separate configuration files, feel free to close this.

ok I just pushed this in a branch with the URL exemption: epfl-scitas-differentiate_framework_from_packages

@tgamblin Fine with me. Should I close this then?

Just a reminder : if I set everything correctly you should be able to push on epfl-scitas repository. Feel free to do it whenever you see it fit to speed-up iterations on a PR 😄

@alalazo: don't close it; it's the same branch (this will merged when I push it)

@tgamblin ok

ok pushing to EPFL seems to be working. yay!

@alalazo: i think maintaining two files is kind of a pain, and i can't keep all the error codes straight. I switched it to one file, ignored a few checks, and added some custom marking for package.py files so that the url lines are exempted. There is also a script now that the user can just run:

    share/spack/qa/run-flake8

And there is only /.flake8 for the input file to flake8.

@tgamblin I may be missing the obvious, but I don't see the share/spack/qa/run-flake8 in the list of changes...

Nope, looks like I'm missing the obvious.

Why did this PR remove the yapf style?

@trws I think it was removed because we were using the default (pep8)

Makes sense. Do we have an autopep8 package in the works?

On 15 May 2016, at 0:12, Massimiliano Culpo wrote:

@trws I think it was removed because we were using the default (pep8)

---

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#929 (comment)