[WIP ]Address E302 and F999 in spack create template#926
[WIP ]Address E302 and F999 in spack create template#926hegner wants to merge 3 commits intospack:developfrom
Conversation
8091c7e to
9a5ed2c
Compare
|
@tgamblin - I am currently going through cmd/create.py to fix the template to follow your new rules. On checking that very file now for coding rules, yet another whitespace checker (E 241) really kills the nice formatting. Same with the line length, where I wouldn't like splitting up some of the strings in there into two lines. I even have a syntax error false-positive. Just have a look at your logs ;-) |
|
Seems the configure commands have very late binding. My attempt to fix doesn't help -> closing |
|
Re-opening after discussion on #924 . Requires converging on rules before finishing |
|
@hegner: I like the narrow column width because it gets me lots of terminals side-by-side on a laptop and even more on a big screen. It's also in PEP8. I just added |
|
@tgamblin - thanks. makes it much easier. |
|
@hegner: We've added an exception for |
|
@tgamblin - thanks. happy you don't want to be that strict. |
With introducing coding rules, the template should follow it as well.
This fix does not address E203 (spaces before comma), which are used in the formatting of the list of versions.