Skip to content

[WIP ]Address E302 and F999 in spack create template#926

Closed
hegner wants to merge 3 commits intospack:developfrom
hegner:bugfix/templatestyle
Closed

[WIP ]Address E302 and F999 in spack create template#926
hegner wants to merge 3 commits intospack:developfrom
hegner:bugfix/templatestyle

Conversation

@hegner
Copy link
Copy Markdown

@hegner hegner commented May 10, 2016

With introducing coding rules, the template should follow it as well.
This fix does not address E203 (spaces before comma), which are used in the formatting of the list of versions.

@hegner hegner force-pushed the bugfix/templatestyle branch from 8091c7e to 9a5ed2c Compare May 10, 2016 11:31
@hegner hegner changed the title Address E302 and F999 in spack create template [WIP ]Address E302 and F999 in spack create template May 10, 2016
@hegner
Copy link
Copy Markdown
Author

hegner commented May 10, 2016

@tgamblin - I am currently going through cmd/create.py to fix the template to follow your new rules. On checking that very file now for coding rules, yet another whitespace checker (E 241) really kills the nice formatting. Same with the line length, where I wouldn't like splitting up some of the strings in there into two lines. I even have a syntax error false-positive. Just have a look at your logs ;-)

@hegner
Copy link
Copy Markdown
Author

hegner commented May 10, 2016

Seems the configure commands have very late binding. My attempt to fix doesn't help -> closing

@hegner hegner closed this May 10, 2016
@hegner
Copy link
Copy Markdown
Author

hegner commented May 10, 2016

Re-opening after discussion on #924 . Requires converging on rules before finishing

@hegner hegner reopened this May 10, 2016
@tgamblin
Copy link
Copy Markdown
Member

@hegner: I like the narrow column width because it gets me lots of terminals side-by-side on a laptop and even more on a big screen. It's also in PEP8. I just added E241 to the exception list in #929, and i added a share/spack/qa/run-flake8 script that will run the checks locally so it's easier to iterate.

@hegner
Copy link
Copy Markdown
Author

hegner commented May 11, 2016

@tgamblin - thanks. makes it much easier.

@tgamblin
Copy link
Copy Markdown
Member

@hegner: We've added an exception for import * in the PEP8 rules. The intent with the packages is really to make it easy for packagers -- I think allowing them to always use from spack import * is fine. So closing this one -- unless you really want explicit imports in packages for some non-PEP8 reason :)

@tgamblin tgamblin closed this May 16, 2016
@hegner
Copy link
Copy Markdown
Author

hegner commented May 16, 2016

@tgamblin - thanks. happy you don't want to be that strict.

olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants