Add extra_rpath paths into rpath commands for openmpi wrappers.#8687
Merged
scheibelp merged 1 commit intospack:developfrom Jul 30, 2018
jrood-nrel:openmpi_rpaths
Merged
Add extra_rpath paths into rpath commands for openmpi wrappers.#8687scheibelp merged 1 commit intospack:developfrom jrood-nrel:openmpi_rpaths
scheibelp merged 1 commit intospack:developfrom
jrood-nrel:openmpi_rpaths
Conversation
Member
Author
|
@alalazo Does this seem like a reasonable thing to do? I feel like it is a necessity, otherwise I am not able to use OpenMPI on machines exhibiting this behavior and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my proposed solution for #8670 . It solved my problem where I use a GCC not installed in
/usrfor example, withextra_rpathsset to point to that GCC's libraries. Then when I build OpenMPI > 1.10.x usingfabrics=verbs, which uses--with-verbsduring OpenMPI configure, it finds the infiniband drivers in/usr/lib64so then it adds-Wl,-rpath -Wl,/usr/lib64to the OpenMPI wrappers. So then when I use the OpenMPI module to build other random software outside of Spack, the wrappers rpath/usr/lib64into the executable which then has GLIBC, GLIBCXX runtime errors due to it picking up libraries in/usr/lib64which is the system GCC, rather than my GCC I'm actually using which is installed elsewhere.Therefore this pull request adds in the directories from
compilers.yamlextra_rpathsinto the OpenMPI wrappers using rpath as well. After testing it, it solves the problem I was having with OpenMPI 3.1.0 for example when creating executables with its wrappers.